Re: [PATCH] irqchip/riscv-intc: Mark INTC nodes for secondary CPUs as initialized.

[Anup Patel]

On Tue, Sep 26, 2023 at 3:59 PM Dmitry Dunaev <dunaev@xxxxxxxx> wrote:
>
> The current Linux driver irq-riscv-intc initialize IRQ domain only once,
> when init function called on primary hart. In other cases no IRQ domain is
> created and no operation on interrupt-controller node is performed.
> This is cause of that no common Linux driver can use per-cpu interrupts
> mapped to several CPUs because fwnode of secondary cores INTC is not
> marked as initialized. This device is always will be marked as deferred.
> For example the system with devicetree
>
>     cpu0: cpu@0 {
>         cpu0_intc: interrupt-controller {
>             interrupt-controller;
>             compatible = riscv,cpu-intc;
>         };
>     };
>
>     cpu1: cpu@1 {
>         cpu1_intc: interrupt-controller {
>             interrupt-controller;
>             compatible = riscv,cpu-intc;
>         };
>     };
>
>     buserr {
>         compatible = riscv,buserr;
>         interrupts-extended = <&cpu0_intc 16 &cpu1_intc 16>;
>     };
>
> will always report 'buserr' node as deferred without calling any
> bus probe function.
>
> This patch will mark all secondary nodes passed to irq-riscv-intc
> driver init function as initialized to be able to act as correct
> IRQ phandle node.
>
> Signed-off-by: Dmitry Dunaev <dunaev@xxxxxxxx>
> ---
>  drivers/irqchip/irq-riscv-intc.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c
> index 4adeee1bc391..c01a4e8d4983 100644
> --- a/drivers/irqchip/irq-riscv-intc.c
> +++ b/drivers/irqchip/irq-riscv-intc.c
> @@ -155,8 +155,10 @@ static int __init riscv_intc_init(struct device_node *node,
>          * for each INTC DT node. We only need to do INTC initialization
>          * for the INTC DT node belonging to boot CPU (or boot HART).
>          */
> -       if (riscv_hartid_to_cpuid(hartid) != smp_processor_id())
> +       if (riscv_hartid_to_cpuid(hartid) != smp_processor_id()) {
> +               fwnode_dev_initialized(of_node_to_fwnode(node), true);

There is already a patch on LKML to address this.
https://www.spinics.net/lists/kernel/msg4929886.html

>                 return 0;
> +       }
>
>         return riscv_intc_init_common(of_node_to_fwnode(node));
>  }
> @@ -179,8 +181,10 @@ static int __init riscv_intc_acpi_init(union acpi_subtable_headers *header,
>          * for each INTC. We only do INTC initialization
>          * for the INTC belonging to the boot CPU (or boot HART).
>          */
> -       if (riscv_hartid_to_cpuid(rintc->hart_id) != smp_processor_id())
> +       if (riscv_hartid_to_cpuid(rintc->hart_id) != smp_processor_id()) {
> +               fwnode_dev_initialized(of_node_to_fwnode(node), true);
>                 return 0;
> +       }

We don't need this change for ACPI because we don't have devlink
dependency between devices and INTC.

Regards,
Anup

>
>         fn = irq_domain_alloc_named_fwnode("RISCV-INTC");
>         if (!fn) {
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-riscv