Re: [PATCH 1/3] rtl8192e: renamed (1) mixed case variable

From: Greg KH
Date: Tue Sep 26 2023 - 05:09:09 EST


On Mon, Sep 25, 2023 at 11:11:55AM -0400, Gary Rookard wrote:
> Renamed (1) prototype variable that was written in mixed case.
> HTUpdateDefaultSetting -> ht_update_default_setting
>
> Linux kernel coding style "cleanup".
> No change in runtime logic.
>
> Signed-off-by: Gary Rookard <garyrookard@xxxxxxxxxxxx>
> ---
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 5517b9df65be..1a3dd4dcad81 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1807,7 +1807,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info,
> void HTSetConnectBwMode(struct rtllib_device *ieee,
> enum ht_channel_width bandwidth,
> enum ht_extchnl_offset Offset);
> -void HTUpdateDefaultSetting(struct rtllib_device *ieee);
> +void ht_update_default_setting(struct rtllib_device *ieee);
> void HTConstructCapabilityElement(struct rtllib_device *ieee,
> u8 *posHTCap, u8 *len,
> u8 isEncrypt, bool bAssoc);
> --
> 2.41.0
>
>

You just broke the build?

Also, you sent 3 patches that do different things, yet have identical
subject lines, that's obviously not correct.

Please fix up and resend a v2 series.

thanks,

greg k-h