Re: [PATCH V2 2/2] arm64: dts: Add watchdog node for Amlogic C3 SoCs

From: Conor Dooley
Date: Tue Sep 26 2023 - 04:04:08 EST


On Tue, Sep 26, 2023 at 01:55:12PM +0800, Huqiang Qin wrote:
> Add watchdog device.
>
> Signed-off-by: Huqiang Qin <huqiang.qin@xxxxxxxxxxx>
> ---
>
> V1 -> V2: Increase compatibles of C3 watchdog.
>
> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> index 998f5050795c..2ad1f8eef199 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> @@ -81,6 +81,12 @@ apb4: bus@fe000000 {
> #size-cells = <2>;
> ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>
> + watchdog@2100 {
> + compatible = "amlogic,c3-wdt", "amlogic,t7-wdt";

Does this pass dtbs_check?
The binding patch doesn't seem to permit this combo..

> + reg = <0x0 0x2100 0x0 0x10>;
> + clocks = <&xtal>;
> + };
> +
> periphs_pinctrl: pinctrl@4000 {
> compatible = "amlogic,c3-periphs-pinctrl";
> #address-cells = <2>;
> --
> 2.42.0
>

Attachment: signature.asc
Description: PGP signature