Re: [RFC PATCH v2 1/9] pstore: move pstore creator id, section type and record struct to common header

From: Shuai Xue
Date: Tue Sep 26 2023 - 02:47:26 EST




On 2023/9/26 01:13, Kees Cook wrote:
> On Mon, Sep 25, 2023 at 03:44:18PM +0800, Shuai Xue wrote:
>> Move pstore creator id, section type and record struct to the common
>> header, so that it can be use by MCE and GHES driver.
>
> I would prefer this was not in the pstore header -- this is a backend
> detail that should stay in backend headers.
>
> -Kees
>

Hi, Kees,

Which file do you prefer? Do you mean "include/linux/cper.h", it defines
the standard CPER sections, e.g. CPER_SEC_PLATFORM_MEM, CPER_SEC_PCIE, etc.

Thank you for comments.

Best Regards,
Shuai