Re: [PATCH v6 4/8] hugetlb: perform vmemmap restoration on a list of pages

From: Muchun Song
Date: Mon Sep 25 2023 - 22:28:23 EST




> On Sep 26, 2023, at 07:48, Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:
>
> The routine update_and_free_pages_bulk already performs vmemmap
> restoration on the list of hugetlb pages in a separate step. In
> preparation for more functionality to be added in this step, create a
> new routine hugetlb_vmemmap_restore_folios() that will restore
> vmemmap for a list of folios.
>
> This new routine must provide sufficient feedback about errors and
> actual restoration performed so that update_and_free_pages_bulk can
> perform optimally.
>
> Special care must be taken when encountering an error from
> hugetlb_vmemmap_restore_folios. We want to continue making as much
> forward progress as possible. A new routine bulk_vmemmap_restore_error
> handles this specific situation.
>
> Signed-off-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>

Thanks for your continue working on this.

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>