Re: [PATCH] cifs: avoid possible NULL dereference

[Su Hui]

On 2023/9/25 23:07, Dan Carpenter wrote:
> On Mon, Sep 25, 2023 at 12:52:21PM +0800, Su Hui wrote:
> > diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
> > index 2108b3b40ce9..37eed057ded0 100644
> > --- a/fs/smb/client/file.c
> > +++ b/fs/smb/client/file.c
> > @@ -4878,6 +4878,12 @@ void cifs_oplock_break(struct work_struct *work)
> >   	struct cifsFileInfo *cfile = container_of(work, struct cifsFileInfo,
> >   						  oplock_break);
> >   	struct inode *inode = d_inode(cfile->dentry);
> > +
> > +	if (!inode) {
> > +		cifs_dbg(FYI, "%s : failed to find inode\n", __func__);
> > +		return;
> > +	}
> > +
> Are we allowing this in the middle of the declaration block these days?
Really sorry for this, I will modify it right now.
Thanks for your reminder!

Su Hui

> >   	struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);
> >   	struct cifsInodeInfo *cinode = CIFS_I(inode);
> >   	struct cifs_tcon *tcon;
>
> regards,
> dan carpenter