Re: [PATCH net-next v3 6/8] net: dsa: vsc73xx: introduce tag 8021q for vsc73xx

[Paweł Dembicki]

wt., 12 wrz 2023 o 23:39 Vladimir Oltean <olteanv@xxxxxxxxx> napisał(a):
>
> Hi Pawel,

Hi Vladimir,

>
> On Tue, Sep 12, 2023 at 02:22:00PM +0200, Pawel Dembicki wrote:
> > This commit introduces a new tagger based on 802.1q tagging.
> > It's designed for the vsc73xx driver. The VSC73xx family doesn't have
> > any tag support for the RGMII port, but it could be based on VLANs.
> >
> > Signed-off-by: Pawel Dembicki <paweldembicki@xxxxxxxxx>
> > ---
> > diff --git a/net/dsa/tag_vsc73xx_8021q.c b/net/dsa/tag_vsc73xx_8021q.c
> > new file mode 100644
> > index 000000000000..9093a71e6eb0
> > --- /dev/null
> > +++ b/net/dsa/tag_vsc73xx_8021q.c
> > @@ -0,0 +1,91 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > +/* Copyright (C) 2022 Pawel Dembicki <paweldembicki@xxxxxxxxx>
>
> 2022-2023 by now, maybe?
>
> > + * Based on tag_sja1105.c:
> > + * Copyright (c) 2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> > + */
> > +#include <linux/dsa/8021q.h>
> > +
> > +#include "tag.h"
> > +#include "tag_8021q.h"
> > +
> > +#define VSC73XX_8021Q_NAME "vsc73xx-8021q"
> > +
> > +static struct sk_buff *vsc73xx_xmit(struct sk_buff *skb, struct net_device *netdev)
> > +{
> > +     struct dsa_port *dp = dsa_slave_to_port(netdev);
> > +     u16 queue_mapping = skb_get_queue_mapping(skb);
> > +     u16 tx_vid = dsa_tag_8021q_standalone_vid(dp);
> > +     u8 pcp;
> > +
> > +     if (skb->offload_fwd_mark) {
> > +             unsigned int bridge_num = dsa_port_bridge_num_get(dp);
> > +             struct net_device *br = dsa_port_bridge_dev_get(dp);
> > +
> > +             if (br_vlan_enabled(br))
> > +                     return skb;
> > +
> > +             tx_vid = dsa_tag_8021q_bridge_vid(bridge_num);
> > +     }
> > +
> > +     pcp = netdev_txq_to_tc(netdev, queue_mapping);
> > +
> > +     return dsa_8021q_xmit(skb, netdev, ETH_P_8021Q,
> > +                           ((pcp << VLAN_PRIO_SHIFT) | tx_vid));
> > +}
> > +
> > +static void vsc73xx_vlan_rcv(struct sk_buff *skb, int *source_port,
> > +                          int *switch_id, int *vbid, u16 *vid)
> > +{
> > +     if (vid_is_dsa_8021q(skb_vlan_tag_get(skb) & VLAN_VID_MASK))
> > +             return dsa_8021q_rcv(skb, source_port, switch_id, vbid);
> > +
> > +     /* Try our best with imprecise RX */
> > +     *vid = skb_vlan_tag_get(skb) & VLAN_VID_MASK;
> > +}
> > +
> > +static struct sk_buff *vsc73xx_rcv(struct sk_buff *skb, struct net_device *netdev)
> > +{
> > +     int src_port = -1, switch_id = -1, vbid = -1;
> > +     u16 vid;
> > +
> > +     if (skb_vlan_tag_present(skb)) {
> > +             /* Normal traffic path. */
> > +             vsc73xx_vlan_rcv(skb, &src_port, &switch_id, &vbid, &vid);
> > +     } else {
> > +             netdev_warn(netdev, "Couldn't decode source port\n");
> > +             return NULL;
> > +     }
> > +
> > +     if (vbid >= 1)
> > +             skb->dev = dsa_tag_8021q_find_port_by_vbid(netdev, vbid);
> > +     else if (src_port == -1 || switch_id == -1)
> > +             skb->dev = dsa_find_designated_bridge_port_by_vid(netdev, vid);
> > +     else
> > +             skb->dev = dsa_master_find_slave(netdev, switch_id, src_port);
>
> Hmm, this isn't looking too good.
>
> I think the fact that you had to add my copyright on what should be such
> a simple thing as a VLAN-based tagger is a bad sign :)
>
> It's time to consolidate some more stuff that currently lives in
> tag_sja1105 and move it into tag_8021q so that you can reuse it more
> easily.
>
> I've prepared some (only compile-tested) patches on this branch here:
> https://github.com/vladimiroltean/linux/commits/pawel-dembicki-vsc73xx-v3
>
> I need to double-check that they don't introduce regressions,

I tested it on my device and I couldn't find any regressions. vlan
filtering and tagging work as expected.

> and we
> should discuss the merging strategy. Probably you're going to submit
> them together with your patch set.

I prepared the v4 patch series. Please look if that format is ok with you.
https://github.com/CHKDSK88/linux/commits/vsc73xx-vlan-net-next

>
> With that, you can drop my part of the copyright :) The remainder should
> look like straightforward use of API which can be written in only a
> limited number of ways.

Now it is much simpler.

>
> > +     if (!skb->dev) {
> > +             netdev_warn(netdev, "Couldn't decode source port\n");
> > +             return NULL;
> > +     }
> > +
> > +     dsa_default_offload_fwd_mark(skb);
> > +
> > +     if (dsa_port_is_vlan_filtering(dsa_slave_to_port(skb->dev)) &&
> > +         eth_hdr(skb)->h_proto == htons(ETH_P_8021Q))
> > +             __vlan_hwaccel_clear_tag(skb);
>
> Why do you need to do this? We send VLAN-tagged packets to the
> VLAN-aware bridge intentionally, so that it knows what VLAN they come
> from (in the dsa_find_designated_bridge_port_by_vid() case). So don't
> strip it if it's not causing a problem.
>

I dropped it in v4. I needed it when I started with this patch series,
because bridge in vlan filtering causes double tagged frames (one from
hardware and one from bridge). But after recent changes it is useless
and it could be dropped because vlan works as expected without it.

> > +
> > +     return skb;
> > +}