Re: [PATCH v2 19/19] staging: iio: resolver: ad2s1210: add triggered buffer support

[David Lechner]

On Sun, Sep 24, 2023 at 1:17 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Thu, 21 Sep 2023 09:44:00 -0500
> David Lechner <dlechner@xxxxxxxxxxxx> wrote:
>
...
> > +             /* REVIST: we can read 3 bytes here and also get fault flags */
>
> Given we have fault detection outputs, does it make sense to do so?
> Or should we just rely on those triggering an interrupt?
>
> > +             ret = spi_read(st->sdev, st->rx, 2);
>

I'm thinking the former would be better, but I have a pending inquiry with ADI
to get more info on this since the fault pins and/or fault registers
don't seem to
be working quite like the datasheet says they should (I am seeing fault bits set
in the register without the fault pins being asserted).