Re: [PATCH v10 0/7] Add metrics for Arm CMN

From: Ian Rogers
Date: Mon Sep 25 2023 - 12:37:31 EST


On Sun, Sep 24, 2023 at 10:58 PM Jing Zhang <renyu.zj@xxxxxxxxxxxxxxxxx> wrote:
>
> Changes since v8:
> - Add fully match identifier check as suggested by Ian.
> - Link: https://lore.kernel.org/lkml/1695037955-107983-1-git-send-email-renyu.zj@xxxxxxxxxxxxxxxxx/
>
> Jing Zhang (7):
> perf pmu: "Compat" supports regular expression matching identifiers
> perf metric: "Compat" supports regular expression matching identifiers
> perf jevents: Support EventidCode and NodeType
> perf test: Make matching_pmu effective
> perf test: Add pmu-event test for "Compat" and new event_field.
> perf jevents: Add support for Arm CMN PMU aliasing
> perf vendor events: Add JSON metrics for Arm CMN

Thanks for the patience with all the to and fro. I was able to test
the series with "git am -3" to get around a merge issue on
perf-tools-next.

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
Tested-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> .../pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 266 +++++++++++++++++++++
> .../pmu-events/arch/arm64/arm/cmn/sys/metric.json | 74 ++++++
> .../pmu-events/arch/test/test_soc/sys/uncore.json | 8 +
> tools/perf/pmu-events/empty-pmu-events.c | 8 +
> tools/perf/pmu-events/jevents.py | 11 +-
> tools/perf/tests/pmu-events.c | 65 ++++-
> tools/perf/util/metricgroup.c | 2 +-
> tools/perf/util/pmu.c | 27 ++-
> tools/perf/util/pmu.h | 1 +
> 9 files changed, 456 insertions(+), 6 deletions(-)
> create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metric.json
>
> --
> 1.8.3.1
>