Re: [PATCH v2 01/19] dt-bindings: iio: resolver: add devicetree bindings for ad2s1210

From: David Lechner
Date: Mon Sep 25 2023 - 11:54:48 EST


On Sun, Sep 24, 2023 at 11:57 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Thu, 21 Sep 2023 09:43:42 -0500
> David Lechner <dlechner@xxxxxxxxxxxx> wrote:
>
...
> > + fault-gpios:
> > + description:
> > + GPIO lines connected to the LOT and DOS pins. These pins combined indicate
> > + the type of fault present, if any. As these pins a pulled low to indicate
> > + a fault condition, they should be configured as GPIO_ACTIVE_LOW.
>
> What if someone is being odd and connected only 1 of them?
> It's annoying how often people run out of pins and do things like this.
>
> > + minItems: 2
> > + maxItems: 2
> > +
In this case the two lines are not independent. If both lines are
asserted, it does
not mean that both LOT and DOS faults exists but rather it means that a LOS
fault exists. So it would seem problematic to allow one without the other here.