Re: [PATCH v11 1/5] staging: vc04_services: vchiq_arm: Add new bus type and device type

[Dan Carpenter]

On Sat, Sep 23, 2023 at 07:57:51PM +0530, Umang Jain wrote:
> Hi Dan,
> 
> On 9/14/23 12:25 PM, Dan Carpenter wrote:
> > On Thu, Sep 14, 2023 at 01:23:50AM +0530, Umang Jain wrote:
> > > +static int vchiq_bus_type_match(struct device *dev, struct device_driver *drv)
> > > +{
> > > +	if (dev->bus == &vchiq_bus_type &&
> > > +	    strcmp(dev_name(dev), drv->name) == 0)
> > > +		return 1;
> > > +
> > > +	return 0;
> > > +}
> > I was not going to comment on this, because it's unfair to nitpick a
> > v11 patch...  But since you're going to have to redo it anyway, could
> > you make this function bool and change it to return true/false.
> > 
> > static bool vchiq_bus_type_match(struct device *dev, struct device_driver *drv)
> 
> Perhaps the return value can be true/false, but return type should always be
> 'int'
> 

Oh.  Sorry, I didn't look carefully.

Btw, you don't need to tip toe around telling me I'm wrong.  Just say
"That won't compile, dummy."  I'm a big boy, and I can admit when I make
mistakes.  ;)

regards,
dan carpenter