Re: [PATCH 2/3] iio: imu: mpu6050: add level shifter flag

[Andreas Kemnade]

On Mon, 25 Sep 2023 14:07:58 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Mon, Sep 25, 2023 at 1:26 AM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
> >
> > Some boards fail in magnetometer probe if flag is not set.  
> 
> Which flag? Can you elaborate a bit more?
> 
well see $subj. The level shifter flag.

> Does it deserve the Fixes tag?
> 
As there are only certain boards affected, they would also have
to add the flag in dtb, I do not think it deservers a Fixes tag.
Even in the board I have here, there are basically two
mpu9150 connected per cable, only one of them needs the flag.

> ...
> 
> >         unsigned int val;
> >         int ret;  
> 
> > +       ret = regmap_update_bits(st->map, 0x1, 0x80,
> > +                                st->level_shifter ? 0x80 : 0);  
> 
> This is a bit cryptic, what does 1 stand for?
> 
Well, I do not find anything in
https://invensense.tdk.com/wp-content/uploads/2015/02/MPU-9150-Register-Map.pdf
I have just found a similar line in the ancient 3.0 vendor kernel. No symbolic
names there.

Regards,
Andreas