Re: [PATCH net-next v8 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA

[Yunsheng Lin]

On 2023/9/25 18:37, Ilias Apalodimas wrote:
> Hi
> 
> On Wed, 20 Sept 2023 at 11:59, Yunsheng Lin <linyunsheng@xxxxxxxxxx> wrote:
>>
>> On 2023/9/15 16:28, Jesper Dangaard Brouer wrote:
>>> Hi Lin,
>>>
>>> This looks reasonable, but given you are changing struct-page
>>> (include/linux/mm_types.h) we need to MM-list <linux-mm@xxxxxxxxx>.
>>> Also Cc Wilcox.
>>>
>>> I think it was Ilias and Duyck that validated the assumptions, last time
>>> this patch was discussed. Thus I want to see their review before this is
>>> applied.
>>
>> FWIW, PAGE_SIZE aligned buffer being PAGE_SIZE aligned in DMA is
>> validated by Duyck:
>> https://lore.kernel.org/all/CAKgT0UfeUAUQpEffxnkc+gzXsjOrHkuMgxU_Aw0VXSJYKzaovQ@xxxxxxxxxxxxxx/
>>
>> And I had done researching to find out there seems to be no combination of
>> the above arch with an address space >16TB:
>> https://lore.kernel.org/all/2b570282-24f8-f23b-1ff7-ad836794baa9@xxxxxxxxxx/
> 
> Apologies for the late reply.  I just saw you sent a v9, I'll review
> that instead, but I am traveling right now, will take a while

Actually there is a newer v10, see:
https://lore.kernel.org/all/20230922091138.18014-2-linyunsheng@xxxxxxxxxx/

Thanks for the time reviewing.

> 
> Thanks
> /Ilias