Re: [PATCH V3 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible

From: Krzysztof Kozlowski
Date: Mon Sep 25 2023 - 06:40:43 EST


On 25/09/2023 12:31, Sricharan Ramabadhran wrote:
>
>
> On 9/25/2023 12:16 PM, Krzysztof Kozlowski wrote:
>> On 25/09/2023 04:06, Sricharan Ramabadhran wrote:
>>>
>>>
>>> On 9/23/2023 5:14 PM, Krzysztof Kozlowski wrote:
>>>> On 22/09/2023 13:51, Sricharan R wrote:
>>>>> From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
>>>>>
>>>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
>>>>
>>>> Then why do you allow two interrupts?
>>>>
>>> infact there is only one interrupt. Will fix in the binding
>>> description.
>>
>> Description? So you still allow two interrupts? No, this must be
>> constrained in allOf:if:then.
>>
>
> ok, it should be fine to add this new compatible to the existing
> allof:if:then block of v1 targets ? (Because they also have same
> single interrupt (uplow) constraint)

Yes.

Best regards,
Krzysztof