Re: [RFC PATCH v3 4/7] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display

[Paul Cercueil]

Le lundi 25 septembre 2023 à 19:48 +1000, John Watts a écrit :
> On Mon, Sep 25, 2023 at 11:43:26AM +0200, Paul Cercueil wrote:
> > From what I can see, you have a panel with a NV3052C chip, so the
> > existing initialization sequence should already work.
> 
> It has some differences that I don't know if are important.

Unless you can explain what they do and why they are needed, I'd say
they are not important :)

> 
> > The NV3052C datasheet does not give any settings for a 640x480
> > panel, I
> > only see suggested settings for a 720x1280 vertical panel.
> > 
> > Unless you have a min/max range specified, the values you see in
> > there
> > are only suggestions for a working setup, that doesn't mean they
> > are
> > the only recommended ones.
> 
> The panel datasheet has these values.

Again, doesn't mean that you have to use these.

>From what I can see, all you need to support your Fascontek panel with
the nv3052c driver, is to add the SPI ID and compatible strings.

Cheers,
-Paul