Re: [RFC PATCH v3 4/7] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display

[Paul Cercueil]

Le lundi 25 septembre 2023 à 19:21 +1000, John Watts a écrit :
> On Mon, Sep 25, 2023 at 11:12:29AM +0200, Paul Cercueil wrote:
> > Hi John,
> > 
> > Just to be sure, your fascontek panel won't work with the
> > initialization sequence of the leadtek panel?
> 
> Yes, it does work.

OK, why not use the leadtek's initialization sequence then?

>From what I can see, you have a panel with a NV3052C chip, so the
existing initialization sequence should already work.

> 
> > Did you try with the existing display modes? If you can afford the
> > 24
> > MHz clock (and if it works with your panel) it will give you a
> > perfect
> > 60.0 Hz refresh rate, while this mode above will give you above
> > 59.93
> > Hz (which is not that bad though).
> 
> No I didn't test with this.
> 
> In general I don't feel comfortable submitting code that strays from
> what is
> recommended by the manufacturer.

The NV3052C datasheet does not give any settings for a 640x480 panel, I
only see suggested settings for a 720x1280 vertical panel.

Unless you have a min/max range specified, the values you see in there
are only suggestions for a working setup, that doesn't mean they are
the only recommended ones.

Cheers,
-Paul