Re: [PATCH v2 1/2] leds: pca955x: Convert enum->pointer for data in the match tables

[Andy Shevchenko]

On Sat, Sep 23, 2023 at 06:19:20PM +0100, Biju Das wrote:
> Convert enum->pointer for data in the match tables, so that
> device_get_match_data() can do match against OF/ACPI/I2C tables, once i2c
> bus type match support added to it.
> 
> Replace enum->struct *pca955x_chipdefs for data in the match table.
> Simplify the probe() by replacing device_get_match_data() and ID lookup
> for retrieving data by i2c_get_match_data().
> 
> While at it, add const definition to pca955x_chipdefs[].

...

> -	struct pca955x_chipdef	*chipdef;
> +	const struct pca955x_chipdef	*chipdef;

No need to preserve TAB(s) here.

Otherwise looks good to me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko