Re: [PATCH 1/2] ASoC: dt-bindings: fsl_rpmsg: List DAPM endpoints ignoring suspend

From: Krzysztof Kozlowski
Date: Mon Sep 25 2023 - 02:51:57 EST


On 25/09/2023 04:48, Chancel Liu wrote:
> Add a property to list DAPM endpoints which mark paths between these
> endpoints ignoring suspend. These DAPM paths can still be power on when
> system enters into suspend.
>
> Signed-off-by: Chancel Liu <chancel.liu@xxxxxxx>
> ---
> Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml
> index 188f38baddec..ec6e09eab427 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml
> @@ -91,6 +91,12 @@ properties:
> - rpmsg-audio-channel
> - rpmsg-micfil-channel
>
> + fsl,lpa-widgets:

What is LPA? It's not explained in property description.

> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> + description: |
> + A list of DAPM endpoints which mark paths between these endpoints
> + ignoring suspend.

And how does it differ from audio-routing? Also, you need to explain
what is "suspend" in this context. Bindings are independent of Linux.

Best regards,
Krzysztof