Re: [PATCH v2 17/19] staging: iio: resolver: ad2s1210: convert resolution to devicetree property

[Jonathan Cameron]

On Thu, 21 Sep 2023 09:43:58 -0500
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> Selecting the resolution was implemented as the `bits` sysfs attribute.
> However, the selection of the resolution depends on how the hardware
> is wired and the specific application, so this is rather a job for
> devicetree to describe.
> 
> A new devicetree property `adi,resolution` to specify the resolution
> required for each chip is added and the `bits` sysfs attribute is
> removed.
> 
> Since the resolution is now supplied by a devicetree property, the
> resolution-gpios are now optional and we can allow for the case where
> the resolution pins on the AD2S1210 are hard-wired instead of requiring
> them to be connected to gpios.
> 
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
Good change to see.  Note that mostly I've not commented on patches
where I fully agree with them.