Re: [PATCH] firewire: Annotate struct fw_node with __counted_by

From: Takashi Sakamoto
Date: Sun Sep 24 2023 - 08:55:04 EST


Hi,

On Fri, Sep 22, 2023 at 10:53:35AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct fw_node.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> Cc: linux1394-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> drivers/firewire/core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next branch, thanks.


Regards

Takashi Sakamoto