Re: [PATCH 2/2] scsi: Add comment of target_destroy in scsi_host_template

[Wenchao Hao]

On 2023/9/22 22:53, Bart Van Assche wrote:
> On 9/22/23 02:38, Wenchao Hao wrote:
> > Add comment to tell callback function target_destroy of
> > scsi_host_template is called in atomic context.
> >
> > Signed-off-by: Wenchao Hao <haowenchao2@xxxxxxxxxx>
> > ---
> >   include/scsi/scsi_host.h | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> > index 49f768d0ff37..a72248fa5adf 100644
> > --- a/include/scsi/scsi_host.h
> > +++ b/include/scsi/scsi_host.h
> > @@ -245,6 +245,9 @@ struct scsi_host_template {
> >        * midlayer calls this point so that the driver may deallocate
> >        * and terminate any references to the target.
> >        *
> > +     * Note: this callback in called with spin_lock held, so donot
> > +     * call functions might cause schedule
> > +     *
>
> This comment should mention which spinlock is held.

Would update, thanks for your review suggestion.

> Thanks,
>
> Bart.