Re: arch/powerpc/kernel/traps.c:1167:19: error: unused function '__parse_fpscr'

[Christophe Leroy]

Le 20/09/2023 à 21:39, kernel test robot a écrit :
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   a229cf67ab851a6e92395f37ed141d065176575a
> commit: ca13c130a43fe3ab625d22ada0a61e5c0b612229 powerpc/4xx: Remove WatchdogHandler() to fix no previous prototype error

Problem already exists before that commit.

Problem was introduced by commit Fixes: b6254ced4da6 ("powerpc/signal: 
Don't manage floating point regs when no FPU")

Christophe


> date:   5 weeks ago
> config: powerpc-kilauea_defconfig (https://download.01.org/0day-ci/archive/20230921/202309210327.WkqSd5Bq-lkp@xxxxxxxxx/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230921/202309210327.WkqSd5Bq-lkp@xxxxxxxxx/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202309210327.WkqSd5Bq-lkp@xxxxxxxxx/
> 
> All errors (new ones prefixed by >>):
> 
>>> arch/powerpc/kernel/traps.c:1167:19: error: unused function '__parse_fpscr' [-Werror,-Wunused-function]
>      1167 | static inline int __parse_fpscr(unsigned long fpscr)
>           |                   ^
>     1 error generated.
> 
> 
> vim +/__parse_fpscr +1167 arch/powerpc/kernel/traps.c
> 
> 14cf11af6cf608 Paul Mackerras    2005-09-26  1166
> 5fad293bcbd48d Kumar Gala        2007-02-07 @1167  static inline int __parse_fpscr(unsigned long fpscr)
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1168  {
> aeb1c0f6ff18f5 Eric W. Biederman 2018-04-17  1169  	int ret = FPE_FLTUNK;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1170
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1171  	/* Invalid operation */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1172  	if ((fpscr & FPSCR_VE) && (fpscr & FPSCR_VX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1173  		ret = FPE_FLTINV;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1174
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1175  	/* Overflow */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1176  	else if ((fpscr & FPSCR_OE) && (fpscr & FPSCR_OX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1177  		ret = FPE_FLTOVF;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1178
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1179  	/* Underflow */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1180  	else if ((fpscr & FPSCR_UE) && (fpscr & FPSCR_UX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1181  		ret = FPE_FLTUND;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1182
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1183  	/* Divide by zero */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1184  	else if ((fpscr & FPSCR_ZE) && (fpscr & FPSCR_ZX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1185  		ret = FPE_FLTDIV;
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1186
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1187  	/* Inexact result */
> dc1c1ca3dcd94c Stephen Rothwell  2005-10-01  1188  	else if ((fpscr & FPSCR_XE) && (fpscr & FPSCR_XX))
> 5fad293bcbd48d Kumar Gala        2007-02-07  1189  		ret = FPE_FLTRES;
> 5fad293bcbd48d Kumar Gala        2007-02-07  1190
> 5fad293bcbd48d Kumar Gala        2007-02-07  1191  	return ret;
> 5fad293bcbd48d Kumar Gala        2007-02-07  1192  }
> 5fad293bcbd48d Kumar Gala        2007-02-07  1193
> 
> :::::: The code at line 1167 was first introduced by commit
> :::::: 5fad293bcbd48d9a2370020cf60e4b4a42559b12 [POWERPC] Fixup error handling when emulating a floating point instruction
> 
> :::::: TO: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>
> :::::: CC: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>
>