Re: [PATCH] xhci: Keep interrupt disabled in initialization until host is running.

From: Greg Kroah-Hartman
Date: Fri Sep 22 2023 - 06:30:19 EST


On Fri, Sep 22, 2023 at 02:51:41PM +0530, Prashanth K wrote:
> From: Hongyu Xie <xy521521@xxxxxxxxx>
>
> [ Upstream commit 808925075fb750804a60ff0710614466c396db4 ]
>
> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
> It's possible that you will receive thousands of interrupt requests
> after initialization for 2.0 roothub. And you will get a lot of
> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
> disabled?". This amount of interrupt requests will cause the entire
> system to freeze.
> This problem was first found on a device with ASM2142 host controller
> on it.
>
> [tidy up old code while moving it, reword header -Mathias]
>
> Cc: stable@xxxxxxxxxx
> Signed-off-by: Hongyu Xie <xiehongyu1@xxxxxxxxxx>
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20220623111945.1557702-2-mathias.nyman@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/host/xhci.c | 34 +++++++++++++++++++++-------------
> 1 file changed, 21 insertions(+), 13 deletions(-)

What stable kernel(s) are you asking this to be applied to?

greg k-h