Re: [PATCH v1] mm/filemap: increase usage of folio_next_index() helper

From: Yin, Fengwei
Date: Thu Sep 21 2023 - 23:01:41 EST




On 9/21/2023 4:15 PM, Minjie Du wrote:
> Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using
> the existing helper folio_next_index() in filemap_map_pages().
>
> Signed-off-by: Minjie Du <duminjie@xxxxxxxx>
Reviewed-by: Yin Fengwei <fengwei.yin@xxxxxxxxx>


Regards
Yin, Fengwei

> ---
> mm/filemap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 4ea4387053e8..f8d0b97f9e94 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -3591,7 +3591,7 @@ vm_fault_t filemap_map_pages(struct vm_fault *vmf,
> addr += (xas.xa_index - last_pgoff) << PAGE_SHIFT;
> vmf->pte += xas.xa_index - last_pgoff;
> last_pgoff = xas.xa_index;
> - end = folio->index + folio_nr_pages(folio) - 1;
> + end = folio_next_index(folio) - 1;
> nr_pages = min(end, end_pgoff) - xas.xa_index + 1;
>
> if (!folio_test_large(folio))