Re: [PATCH 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices

[Joerg Schambacher]

Am 12.09.2023 um 10:15 hat Rob Herring geschrieben:
> On Thu, Sep 07, 2023 at 06:08:51PM +0200, Joerg Schambacher wrote:
> > The TAS5754/6 power amplifiers use the same pcm512x driver with
> > only minor restictions described in the bindings document.
> > 
> > Signed-off-by: Joerg Schambacher <joerg.hifiberry@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/sound/pcm512x.txt     | 22 +++++++++++++++----
> >  1 file changed, 18 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/pcm512x.txt b/Documentation/devicetree/bindings/sound/pcm512x.txt
> > index 3aae3b41bd8e..b16cd0463695 100644
> > --- a/Documentation/devicetree/bindings/sound/pcm512x.txt
> > +++ b/Documentation/devicetree/bindings/sound/pcm512x.txt
> > @@ -1,12 +1,12 @@
> > -PCM512x audio CODECs
> > +PCM512x and TAS575x audio CODECs/amplifiers
> >  
> >  These devices support both I2C and SPI (configured with pin strapping
> > -on the board).
> > +on the board). The TAS575x devices only support I2C.
> >  
> >  Required properties:
> >  
> > -  - compatible : One of "ti,pcm5121", "ti,pcm5122", "ti,pcm5141" or
> > -                 "ti,pcm5142"
> > +  - compatible : One of "ti,pcm5121", "ti,pcm5122", "ti,pcm5141",
> > +                 "ti,pcm5142", "ti,tas5754" or "ti,tas5756"
> >  
> >    - reg : the I2C address of the device for I2C, the chip select
> >            number for SPI.
> > @@ -25,6 +25,7 @@ Optional properties:
> >      through <6>.  The device will be configured for clock input on the
> >      given pll-in pin and PLL output on the given pll-out pin.  An
> >      external connection from the pll-out pin to the SCLK pin is assumed.
> > +    Caution: the TAS-desvices only support gpios 1,2 and 3
> >  
> >  Examples:
> >  
> > @@ -50,3 +51,16 @@ Examples:
> >  		pll-in = <3>;
> >  		pll-out = <6>;
> >  	};
> > +
> > +	tas5756: tas5756@4f {
> > +		compatible = "ti,tas5756";
> 
> Is there anything new here? Just a different compatible doesn't justify 
> another example.
> 
> With that dropped,
> 
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
Thanks for feedback. Actually, there is nothing really new. More to show
the reduced availability of GPIOs. I'm preparing a new version of the
patch and I will drop the example.
--