Re: [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility

From: AngeloGioacchino Del Regno
Date: Thu Sep 21 2023 - 16:21:42 EST


Il 20/09/23 17:03, Laura Nao ha scritto:
On 9/19/23 11:23, AngeloGioacchino Del Regno wrote:
In older devicetrees we had the ChromeOS EC in a node called "cros-ec"
instead of the newer "cros-ec-rpmsg", but this driver is now checking
only for the latter, breaking compatibility with those.

Besides, we can check if the SCP is single or dual core by simply
walking through the children of the main SCP node and checking if
if there's more than one "mediatek,scp-core" compatible node.

Fixes: 1fdbf0cdde98 ("remoteproc: mediatek: Probe SCP cluster on multi-core SCP")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
---
drivers/remoteproc/mtk_scp.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)


Tested on asurada (spherion) and jacuzzi (juniper). The issue was detected by KernelCI, so:

Reported-by: "kernelci.org bot" <bot@xxxxxxxxxxxx>
Tested-by: Laura Nao <laura.nao@xxxxxxxxxxxxx>


Thanks for pointing out the correct Reported-by tag! :-)

Cheers,
Angelo