Re: [PATCH v1 1/6] params: Use sysfs_emit() to instead of scnprintf()

From: Andy Shevchenko
Date: Thu Sep 21 2023 - 16:00:33 EST


On Thu, Sep 21, 2023 at 09:34:13PM +0800, kernel test robot wrote:
>
> Hello,
>
> kernel test robot noticed "WARNING:at_fs/sysfs/file.c:#sysfs_emit" on:
>
> commit: d4004295e5502a1eb3e361e97ea4dd1686046af6 ("[PATCH v1 1/6] params: Use sysfs_emit() to instead of scnprintf()")
> url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/params-Introduce-the-param_unknown_fn-type/20230912-231033
> base: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
> patch link: https://lore.kernel.org/all/20230912150551.401537-1-andriy.shevchenko@xxxxxxxxxxxxxxx/
> patch subject: [PATCH v1 1/6] params: Use sysfs_emit() to instead of scnprintf()
>
> in testcase: trinity
> version: trinity-i386-abe9de86-1_20230429
> with following parameters:
>
> runtime: 300s
> group: group-04
> nr_groups: 5


> what we observed is this issue doesn't always happen. we run the test upon
> this commit almost 500 times, it happened 42 times.
> however, the parent keeps clean.
>
> v6.6-rc1 d4004295e5502a1eb3e361e97ea
> ---------------- ---------------------------
> fail:runs %reproduction fail:runs
> | | |
> :497 8% 42:496 dmesg.EIP:sysfs_emit
> :497 8% 42:496 dmesg.WARNING:at_fs/sysfs/file.c:#sysfs_emit

Cool! I will check this, thank you for the report.

--
With Best Regards,
Andy Shevchenko