Re: [RFC PATCH net-next 1/6] net: ethernet: implement OPEN Alliance control transaction interface

From: Andrew Lunn
Date: Thu Sep 21 2023 - 15:53:49 EST


> Yes, as "struct oa_tc6" and its members are not or going to be accessed
> in the MAC driver, I will consider this as an opaque structure and
> declare it as void *opaque_oa_tc6 in the MAC driver private structure
> "struct lan865x_priv" and will pass to the APIs exported from oa_tc6.c lib.
>
> Is my understanding correct?

Yes.

If the structure is going to be truly opaque, i suggest having it in
the C file, not the H file.

Andrew