Re: [RFC PATCH net-next 1/6] net: ethernet: implement OPEN Alliance control transaction interface

From: Andrew Lunn
Date: Wed Sep 20 2023 - 09:37:31 EST


> Ah ok, I think there is a misunderstanding here. This is related to OPEN
> Alliance protocol. Control transactions consist of one or more control
> commands. Control commands are used by the SPI host to read and write
> registers within the MAC-PHY. Each control commands are composed of a
> 32-bit control command header followed by register data. WNR (write not
> read) bit in the control command header indicates if data is to be
> written to registers (when set) or read from registers (when clear). so
> basically it indicates the type of the control command on the registers.

OK, so this clearly indicates the names are bad and documentation is
missing if i got this completely wrong. Adding kerneldoc to these
functions should help.

Andrew