Re: [PATCH v2 2/5] dt-bindings: serial: document esp32-uart

From: Krzysztof Kozlowski
Date: Wed Sep 20 2023 - 08:35:10 EST


On 20/09/2023 04:26, Max Filippov wrote:
> Add documentation for the ESP32xx UART controllers.
>
> Signed-off-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
>

Thanks for the changes.

> +properties:
> + compatible:
> + enum:
> + - esp,esp32-uart
> + - esp,esp32s3-uart
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks

You need allOf with $ref to serial.yaml# (local serial, not absolute
path). I apologize, I missed this in my previous review.

Best regards,
Krzysztof