Re: [PATCH 00/16] xtensa: fix W=1 build warnings

From: Max Filippov
Date: Wed Sep 20 2023 - 08:11:40 EST


Hi Randy,

On Tue, Sep 19, 2023 at 10:21 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> This series fixes all xtensa W=1 build warnings that I have seen
> with the exception of some in arch/xtensa/boot/. [1]
>
> These have been through defconfig, allnoconfig, tinyconfig, allyesconfig,
> allmodconfig, and many randconfig builds.
>
> [PATCH 01/16] xtensa: FSF: define XCHAL_HAVE_DIV32
> [PATCH 02/16] xtensa: fault: include <asm/traps.h>
> [PATCH 03/16] xtensa: irq: include <asm/traps.h>
> [PATCH 04/16] xtensa: ptrace: add prototypes to <asm/ptrace.h>
> [PATCH 05/16] xtensa: processor.h: add init_arch() prototype
> [PATCH 06/16] xtensa: signal: include headers for function prototypes
> [PATCH 07/16] xtensa: stacktrace: include <asm/ftrace.h> for prototype
> [PATCH 08/16] xtensa: traps: add <linux/cpu.h> for function prototype
> [PATCH 09/16] irqchip: irq-xtensa-mx: include header for missing prototype
> [PATCH 10/16] xtensa: smp: add headers for missing function prototypes
> [PATCH 11/16] xtensa: hw_breakpoing: include header for missing prototype
> [PATCH 12/16] xtensa: tlb: include <asm/tlb.h> for missing prototype
> [PATCH 13/16] xtensa: iss/network: make functions static
> [PATCH 14/16] xtensa: boot: don't add include-dirs
> [PATCH 15/16] xtensa: umulsidi3: fix conditional expression
> [PATCH 16/16] xtensa: boot/lib: add missing prototypes for functions
>
> 1:
> arch/xtensa/boot/boot-elf/bootstrap.S:68: Warning: value 0x1a0003000 truncated to 0xa0003000
>
> arch/xtensa/boot/Makefile | 3 +--
> arch/xtensa/boot/lib/zmem.c | 4 ++++
> arch/xtensa/include/asm/hw_breakpoint.h | 1 +
> arch/xtensa/include/asm/processor.h | 5 +++++
> arch/xtensa/include/asm/ptrace.h | 3 +++
> arch/xtensa/include/asm/smp.h | 1 +
> arch/xtensa/include/asm/tlb.h | 2 ++
> arch/xtensa/kernel/hw_breakpoint.c | 1 +
> arch/xtensa/kernel/irq.c | 1 +
> arch/xtensa/kernel/ptrace.c | 1 -
> arch/xtensa/kernel/signal.c | 2 ++
> arch/xtensa/kernel/smp.c | 1 +
> arch/xtensa/kernel/stacktrace.c | 1 +
> arch/xtensa/kernel/traps.c | 1 +
> arch/xtensa/lib/umulsidi3.S | 4 +++-
> arch/xtensa/mm/fault.c | 1 +
> arch/xtensa/mm/tlb.c | 1 +
> arch/xtensa/platforms/iss/network.c | 4 ++--
> arch/xtensa/variants/fsf/include/variant/core.h | 1 +
> drivers/irqchip/irq-xtensa-mx.c | 1 +
> 20 files changed, 33 insertions(+), 6 deletions(-)
>
> Cc: Chris Zankel <chris@xxxxxxxxxx>
> Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>

Thank you for this nice cleanup. Applied the whole series (except
the first and the last patches, which I replaced with different fixes)
to my xtensa tree.

--
Thanks.
-- Max