Re: [RFC v2 1/5] mm/migrate: fix do_pages_move for compat pointers

From: Arnd Bergmann
Date: Wed Sep 20 2023 - 05:37:12 EST


On Tue, Sep 19, 2023, at 19:09, Gregory Price wrote:
> do_pages_move does not handle compat pointers for the page list.
> correctly. Add in_compat_syscall check and appropriate get_user
> fetch when iterating the page list.
>
> Signed-off-by: Gregory Price <gregory.price@xxxxxxxxxxxx>
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Co-developed-by: Arnd Bergmann <arnd@xxxxxxxx>

Looks correct to me, thanks for fixing it!

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

You can also blame me for breaking it in the first place

Fixes: 5b1b561ba73c ("mm: simplify compat_sys_move_pages")

Arnd