Re: [PATCH] ALSA: hda: cirrus_scodec: Select GPIOLIB for KUnit test

From: Takashi Iwai
Date: Wed Sep 20 2023 - 05:20:24 EST


On Wed, 20 Sep 2023 11:03:38 +0200,
Richard Fitzgerald wrote:
>
> The KUnit test for cirrus_scodec uses GPIO library functions so select
> GPIOLIB in Kconfig.
>
> This fixes the ld failures on builds that didn't already select GPIOLIB.
> ld: vmlinux.o: in function `cirrus_scodec_test_gpio_get':
> sound/pci/hda/cirrus_scodec_test.c:40: undefined reference to
> `gpiochip_get_data'
> ld: vmlinux.o: in function `cirrus_scodec_test_gpio_probe':
> sound/pci/hda/cirrus_scodec_test.c:94: undefined reference to
> `gpiochip_generic_request'
> ld: sound/pci/hda/cirrus_scodec_test.c:94: undefined reference to
> `gpiochip_generic_free'
> ld: sound/pci/hda/cirrus_scodec_test.c:95: undefined reference to
> `devm_gpiochip_add_data_with_key'
>
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309201646.NnjfKPWk-lkp@xxxxxxxxx/
> Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test")

Thanks, applied now.


Takashi