RE: [Intel-xe] [PATCH v2 3/4] drm/xe/gsc: add gsc device support

[Usyskin, Alexander]

> > > diff --git a/drivers/gpu/drm/xe/xe_device.c
> > b/drivers/gpu/drm/xe/xe_device.c
> > > index d6fc06d4c9dc..4d6e2f2b281f 100644
> > > --- a/drivers/gpu/drm/xe/xe_device.c
> > > +++ b/drivers/gpu/drm/xe/xe_device.c
> > > @@ -323,6 +323,8 @@ int xe_device_probe(struct xe_device *xe)
> > >  			goto err_irq_shutdown;
> > >  	}
> > >
> > > +	xe_heci_gsc_init(xe);
> > > +
> >
> > could we place this call earlier in the flow? maybe right after setting up
> mmio?
> > or maybe after pcode init where we confirmed the boot can proceed on
> > discrete?
> 
> Right after xe_irq_install will be ok (as we need working irq to setup)?
> Will try, if this works.
> 

Right after xe_irq_install - not working, but after xe_gt_init_early - it works, will move there in V2

> >
> > >  	err = xe_display_init(xe);
> > >  	if (err)
> > >  		goto err_irq_shutdown;

-- 
Thanks,
Sasha