Re: [RESEND PATCH v6 12/20] drm/mediatek: Refine device table of OVL adaptor

From: CK Hu (胡俊光)
Date: Wed Sep 20 2023 - 02:48:23 EST


Hi, Hsiao-chien:

On Mon, 2023-09-11 at 15:42 +0800, Hsiao Chien Sung wrote:
> - Adjust indentation to align with other files
> - Sort device table in alphabetical order
> - Add sentinel to device table

Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx>

>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@xxxxxxxxxxxx>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> index 114eded8177e..4a5fab5ea51f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> @@ -386,17 +386,10 @@ static int ovl_adaptor_comp_get_id(struct
> device *dev, struct device_node *node,
> }
>
> static const struct of_device_id mtk_ovl_adaptor_comp_dt_ids[] = {
> - {
> - .compatible = "mediatek,mt8195-vdo1-rdma",
> - .data = (void *)OVL_ADAPTOR_TYPE_MDP_RDMA,
> - }, {
> - .compatible = "mediatek,mt8195-disp-merge",
> - .data = (void *)OVL_ADAPTOR_TYPE_MERGE,
> - }, {
> - .compatible = "mediatek,mt8195-disp-ethdr",
> - .data = (void *)OVL_ADAPTOR_TYPE_ETHDR,
> - },
> - {},
> + { .compatible = "mediatek,mt8195-disp-ethdr", .data = (void
> *)OVL_ADAPTOR_TYPE_ETHDR },
> + { .compatible = "mediatek,mt8195-disp-merge", .data = (void
> *)OVL_ADAPTOR_TYPE_MERGE },
> + { .compatible = "mediatek,mt8195-vdo1-rdma", .data = (void
> *)OVL_ADAPTOR_TYPE_MDP_RDMA },
> + { /* sentinel */ }
> };
>
> static int compare_of(struct device *dev, void *data)
> --
> 2.18.0
>