Re: [PATCH v2 2/2] dmaengine: fsl-edma: add trace event support

From: kernel test robot
Date: Tue Sep 19 2023 - 17:47:44 EST


Hi Frank,

kernel test robot noticed the following build warnings:

[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on linus/master v6.6-rc2 next-20230919]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/dmaengine-fsl-emda-add-debugfs-support/20230920-010257
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link: https://lore.kernel.org/r/20230919151430.2919042-3-Frank.Li%40nxp.com
patch subject: [PATCH v2 2/2] dmaengine: fsl-edma: add trace event support
config: arc-randconfig-001-20230920 (https://download.01.org/0day-ci/archive/20230920/202309200524.QTINjSsC-lkp@xxxxxxxxx/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230920/202309200524.QTINjSsC-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309200524.QTINjSsC-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

In file included from include/trace/define_trace.h:102,
from drivers/dma/fsl-edma-trace.h:134,
from drivers/dma/fsl-edma-common.h:238,
from drivers/dma/fsl-edma-trace.c:4:
drivers/dma/./fsl-edma-trace.h: In function 'trace_raw_output_edma_log_io':
>> drivers/dma/./fsl-edma-trace.h:28:19: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat=]
28 | TP_printk("offset %08lx: value %08x",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
drivers/dma/./fsl-edma-trace.h:28:9: note: in expansion of macro 'TP_printk'
28 | TP_printk("offset %08lx: value %08x",
| ^~~~~~~~~
In file included from include/trace/trace_events.h:237:
drivers/dma/./fsl-edma-trace.h:28:31: note: format string is defined here
28 | TP_printk("offset %08lx: value %08x",
| ~~~~^
| |
| long unsigned int
| %08x


vim +28 drivers/dma/./fsl-edma-trace.h

14
15 DECLARE_EVENT_CLASS(edma_log_io,
16 TP_PROTO(struct fsl_edma_engine *edma, void __iomem *addr, u32 value),
17 TP_ARGS(edma, addr, value),
18 TP_STRUCT__entry(
19 __field(struct fsl_edma_engine *, edma)
20 __field(void __iomem *, addr)
21 __field(u32, value)
22 ),
23 TP_fast_assign(
24 __entry->edma = edma;
25 __entry->addr = addr;
26 __entry->value = value;
27 ),
> 28 TP_printk("offset %08lx: value %08x",
29 __entry->addr - __entry->edma->membase, __entry->value)
30 );
31

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki