Re: [PATCH] fs/posix_acl: apply umask if superblock disables ACL support

From: Max Kellermann
Date: Tue Sep 19 2023 - 09:15:55 EST


On Tue, Sep 19, 2023 at 3:10 PM Christian Brauner <brauner@xxxxxxxxxx> wrote:
> Have you verified that commit ac6800e279a2 ("fs: Add missing umask strip
> in vfs_tmpfile") doesn't already fix this?

No, I havn't - I submitted this patch already several years ago, but
it was never merged, and since then, I've been carrying this patch
around in all kernels I ever used. While doing some other kernel work
this week, I decided to resubmit it, because I thought it's a security
vulnerability to ignore the umask. But thanks, it's a good hint, I'll
check that 2022 commit.