Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection

From: Chen-Yu Tsai
Date: Tue Sep 19 2023 - 07:04:44 EST


On Tue, Sep 19, 2023 at 7:02 PM Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
>
> On Fri, 15 Sep 2023, Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote:
> > On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
> >>
> >> The sads returned by drm_edid_to_sad() needs to be freed.
> >>
> >> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
> >> Cc: Guillaume Ranquet <granquet@xxxxxxxxxxxx>
> >> Cc: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx>
> >> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> >> Cc: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>
> >> Cc: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>
> >> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> >> Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> >> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> >> Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
> >> Cc: linux-kernel@xxxxxxxxxxxxxxx
> >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> >> Cc: <stable@xxxxxxxxxxxxxxx> # v6.1+
> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> >
> > Looks correct to me.
> >
> > Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
>
> Thanks for the reviews Chen-Yu and Guillaume. Will you push this to
> drm-misc-next or shall I?

Patches for the MediaTek drm driver go through their own separate tree,
maintained by CK (Chun-Kuang).

ChenYu