Re: [PATCH] ASoC: dt-bindings: tfa9879: Convert to dtschema

From: Rob Herring
Date: Tue Sep 19 2023 - 06:57:50 EST



On Tue, 19 Sep 2023 14:37:39 +0530, Bragatheswaran Manickavel wrote:
> Convert the tfa9879 audio CODEC bindings to DT schema
>
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@xxxxxxxxx>
> ---
> .../bindings/sound/nxp,tfa9879.yaml | 45 +++++++++++++++++++
> .../devicetree/bindings/sound/tfa9879.txt | 23 ----------
> 2 files changed, 45 insertions(+), 23 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/tfa9879.txt
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/sound/nxp,tfa9879.example.dts:22.27-40 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/sound/nxp,tfa9879.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):
MAINTAINERS: Documentation/devicetree/bindings/sound/tfa9879.txt

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230919090739.2448-1-bragathemanick0908@xxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.