Re: [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement

From: Charles Keepax
Date: Tue Sep 19 2023 - 04:51:23 EST


On Mon, Sep 18, 2023 at 12:30:42PM -0700, Randy Dunlap wrote:
> The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ
> to what the core driver selects in order to provide this API.
> This fixes a build error:
>
> aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work':
> cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'
>
> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> Cc: James Schulman <james.schulman@xxxxxxxxxx>
> Cc: David Rhodes <david.rhodes@xxxxxxxxxx>
> Cc: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx
> Cc: patches@xxxxxxxxxxxxxxxxxxxxx
> Cc: Lee Jones <lee@xxxxxxxxxx>
> ---

Someone already sent a fix for this, that is awaiting review:

https://lore.kernel.org/lkml/tencent_E54C7156F583E15FFE320E576E3389C39A08@xxxxxx/

But just incase this one gets picked up:

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles