Re: [PATCH 2/2] tools/power/x86/intel_pstate_tracer: Use pygnuplot package for Gnuplot

From: Swapnil Sapkal
Date: Tue Sep 19 2023 - 03:37:01 EST


Hello Doug,

Sorry for delay in response.

On 9/18/2023 3:13 AM, Doug Smythies wrote:
On 2023.09.17 15:17 Doug wrote:
On Fri, Sep 15, 2023 at 2:31 PM Mario Limonciello
On 9/15/2023 16:15, Doug Smythies wrote:
On 2023.09.15 03:41 Swapnil Sapkal wrote:
...
Not really related, but for a few years now I have been meaning to
change the minimum python version prerequisite to >= 3.0 and
to change the shebang line.
...
Besides the shebang, you should also
use a helper like 2to3 to look for any other changes.

Hi Mario,

I was not aware of the 2to3 helper.
Thank you mentioning it.
The 2to3 helper only changed one line,
which I included in the minimum python version
patch I just submitted.

I tried with installing python3-gnuplot and it worked for me. Initially I
tried with other packages in prerequisites and it didn't worked for me.

I will send v2 removing this patch.

I already did the python 3 patch in January, 2020:
commit e749e09db30c38f1a275945814b0109e530a07b0
tools/power/x86/intel_pstate_tracer: changes for python 3 compatibility

I haven't had any issues since, shebang aside.

... Doug


--
Thanks and Regards,
Swapnil