Re: [PATCH] soundwire: bus: Make IRQ handling conditionally built

From: Randy Dunlap
Date: Mon Sep 18 2023 - 14:55:32 EST




On 9/18/23 09:10, Charles Keepax wrote:
> SoundWire has provisions for a simple callback for the IRQ handling so
> has no hard dependency on IRQ_DOMAIN, but the recent addition of IRQ
> handling was causing builds without IRQ_DOMAIN to fail. Resolve this by
> moving the IRQ handling into its own file and only add it to the build
> when IRQ_DOMAIN is included in the kernel.
>
> Fixes: 12a95123bfe1 ("soundwire: bus: Allow SoundWire peripherals to register IRQ handlers")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309150522.MoKeF4jx-lkp@xxxxxxxxx/
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/soundwire/Makefile | 4 +++
> drivers/soundwire/bus.c | 31 +++----------------
> drivers/soundwire/bus_type.c | 11 +++----
> drivers/soundwire/irq.c | 59 ++++++++++++++++++++++++++++++++++++
> drivers/soundwire/irq.h | 43 ++++++++++++++++++++++++++
> 5 files changed, 115 insertions(+), 33 deletions(-)
> create mode 100644 drivers/soundwire/irq.c
> create mode 100644 drivers/soundwire/irq.h
>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

--
~Randy