Re: [RFC 07/23] filemap: align the index to mapping_min_order in __filemap_add_folio()

From: Luis Chamberlain
Date: Mon Sep 18 2023 - 14:32:09 EST


On Fri, Sep 15, 2023 at 08:48:43PM +0100, Matthew Wilcox wrote:
> On Fri, Sep 15, 2023 at 08:38:32PM +0200, Pankaj Raghav wrote:
> > From: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> >
> > Align the index to the mapping_min_order number of pages while setting
> > the XA_STATE and xas_set_order().
>
> Not sure why this one's necessary either. The index should already be
> aligned to folio_order.

Oh, it was not obvious, would a VM_BUG_ON_FOLIO() be OK then?

> Some bits of it are clearly needed, like checking that folio_order() >=
> min_order.

Thanks,

Luis