Re: [PATCH AUTOSEL 6.5 6/6] thermal/drivers/sun8i: Free calibration nvmem after reading it

From: Sasha Levin
Date: Mon Sep 18 2023 - 13:28:09 EST


On Sat, Sep 09, 2023 at 01:37:19PM +0100, Mark Brown wrote:
On Fri, Sep 08, 2023 at 09:12:54PM -0400, Sasha Levin wrote:
From: Mark Brown <broonie@xxxxxxxxxx>

[ Upstream commit c51592a95f360aabf2b8a5691c550e1749dc41eb ]

The sun8i thermal driver reads calibration data via the nvmem API at
startup, updating the device configuration and not referencing the data
again. Rather than explicitly freeing the nvmem data the driver relies
on devm_ to release it, even though the data is never referenced again.
The allocation is still tracked so it's not leaked but this is notable
when looking at the code and is a little wasteful so let's instead
explicitly free the nvmem after we're done with it.

This is a minor cleanup which as with so much of what's come in today's
backports seems very questionable for stable.

I'll drop this, thanks!

--
Thanks,
Sasha