Re: [RFC PATCH net-next 4/6] net: ethernet: implement data transaction interface

From: Andrew Lunn
Date: Mon Sep 18 2023 - 13:08:02 EST


> >> +#define MAX_ETH_LEN 1536
> >
> > Where do 1536 come from? Maybe this needs an OA_TC6 prefix to make it
> > clear this is specific to this protocol?
> Ah it is a mistake. It is supposed to be an ethernet packet size which
> is 1518 (1500 bytes MTU size + 18 bytes overhead) and it is not from OA.
> It is a mistake and will correct it in the next version.

Please try to express this using ETH_DATA_LEN + sizeof(struct
oa_tc6_overhead). Doing it like this will avoid errors like this since
it is also part documentation.

Andrew