Re: [PATCH v4 26/42] mtd: nand: add support for ts72xx

From: Miquel Raynal
Date: Mon Sep 18 2023 - 09:00:40 EST


Hi Nikita,

devnull+nikita.shubin.maquefel.me@xxxxxxxxxx wrote on Fri, 15 Sep 2023
11:11:08 +0300:

> From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
>
> Technologic Systems has it's own nand controller implementation in CPLD.

I initially agreed to accept a first version of this controller driver
with a legacy API because people were apparently under time pressure to
get this in. I see it's been a couple of months, so this is not that
urgent after all. As the driver is only 166 lines long, I would
strongly prefer a very straight ->exec_op() conversion in order to get
rid of these ugly direct I/O accesses.

Thanks,
Miquèl

> Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> ---
> drivers/mtd/nand/raw/Kconfig | 7 +
> drivers/mtd/nand/raw/Makefile | 1 +
> drivers/mtd/nand/raw/technologic-nand-controller.c | 166 +++++++++++++++++++++
> 3 files changed, 174 insertions(+)
>