Re: [PATCH] tools/power/x86/intel_pstate_tracer: python minimum version

From: Mario Limonciello
Date: Sun Sep 17 2023 - 21:03:46 EST


On 9/17/2023 16:29, Doug Smythies wrote:
From: Doug Smythies <dsmythies@xxxxxxxxx>

Change the minimum python version from 2.7 to 3.6.
Remove a 2.X backwards compatibility line.

Signed-off-by: Doug Smythies <dsmythies@xxxxxxxxx>
---
.../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
index ec3323100e1a..6b0790e6465a 100755
--- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
+++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-2.0-only
# -*- coding: utf-8 -*-
#
@@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval
and generates performance plots.

Prerequisites:
- Python version 2.7.x or higher
+ Python version 3.6.x or higher
gnuplot 5.0 or higher
- gnuplot-py 1.8 or higher
+ phython3-gnuplot 1.8 or higher

Presumably you mean 'python3-gnuplot'.

(Most of the distributions have these required packages. They may be called
gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )


Likewise here too.

@@ -23,7 +23,7 @@ Prerequisites:
see print_help(): for Usage and Output details

"""
-from __future__ import print_function
+
from datetime import datetime
import subprocess
import os
@@ -562,7 +562,7 @@ if __name__ == "__main__":

# Temporary (or perhaps not)
cur_version = sys.version_info
- print('python version (should be >= 2.7):')
+ print('python version (should be >= 3.6):')
print(cur_version)

Is this block printing the version really needed at all?
I don't see 'cur_version' used anywhere else in the file.


# Left as "cleanup" for potential future re-run ability.
--
2.25.1