Re: [PATCH net-next v7 0/2] net: stmmac: Tx coe sw fallback

From: Serge Semin
Date: Sun Sep 17 2023 - 20:36:41 EST


On Sat, Sep 16, 2023 at 02:33:10PM +0800, Rohan G Thomas wrote:
> Hi,
> DW xGMAC IP can be synthesized such that it can support tx checksum
> offloading only for a few initial tx queues. Also as Serge pointed
> out, for the DW QoS IP, tx coe can be individually configured for
> each tx queue. This patchset adds support for tx coe sw fallback for
> those queues that don't support tx coe. Also, add binding for
> snps,coe-unsupported property.

The series looks good to me. Thanks!
Reviewed-by: Serge Semin <fancer.lancer@xxxxxxxxx>

-Serge(y)

>
> changelog v7:
> * Updated commit message.
> * Add blank lines around newly added dt binding.
>
> changelog v6:
> * Reworked patchset to cover DW QoS Ethernet IP also.
>
> changelog v5:
> * As rightly suggested by Serge, reworked redundant code.
>
> changelog v4:
> * Replaced tx_q_coe_lmt with bit flag.
>
> changelog v3:
> * Resend with complete email list.
>
> changelog v2:
> * Reformed binding description.
> * Minor grammatical corrections in comments and commit messages.
>
> Rohan G Thomas (2):
> dt-bindings: net: snps,dwmac: Tx coe unsupported
> net: stmmac: Tx coe sw fallback
>
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++++++++++
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 +++
> include/linux/stmmac.h | 1 +
> 4 files changed, 19 insertions(+)
>
> --
> 2.25.1
>