Re: [PATCH net-next v7 1/2] dt-bindings: net: snps,dwmac: Tx coe unsupported

From: Conor Dooley
Date: Sun Sep 17 2023 - 06:05:08 EST


On Sat, Sep 16, 2023 at 02:33:11PM +0800, Rohan G Thomas wrote:
> Add dt-bindings for coe-unsupported property per tx queue. Some DWMAC
> IPs support tx checksum offloading(coe) only for a few tx queues.
>
> DW xGMAC IP can be synthesized such that it can support tx coe only
> for a few initial tx queues. Also as Serge pointed out, for the DW
> QoS IP tx coe can be individually configured for each tx queue. This
> property is added to have sw fallback for checksum calculation if a
> tx queue doesn't support tx coe.
>
> Signed-off-by: Rohan G Thomas <rohan.g.thomas@xxxxxxxxx>

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index ddf9522a5dc2..5c2769dc689a 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -394,6 +394,11 @@ properties:
> When a PFC frame is received with priorities matching the bitmask,
> the queue is blocked from transmitting for the pause time specified
> in the PFC frame.
> +
> + snps,coe-unsupported:
> + type: boolean
> + description: TX checksum offload is unsupported by the TX queue.
> +
> allOf:
> - if:
> required:
> --
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature