Re: [PATCH v4 5/8] selftests/resctrl: Reorder resctrl FS prep code and benchmark_cmd init

From: Reinette Chatre
Date: Thu Aug 31 2023 - 17:26:03 EST


Hi Ilpo,

On 8/31/2023 4:08 AM, Ilpo Järvinen wrote:
> Benchmark command is initialized before resctrl FS check and
> preparation code that can call ksft_exit_skip(). There is no strong
> reason why the resctrl FS support check and unmounting it (if already
> mounted), has to be done after the benchmark command initialization.
>
> Move benchmark command initialization such that it is done not until
> right before the tests commence. This simplifies rollback handling when
> benchmark command initialization starts to use dynamic allocation (in a
> change following this).
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette